Alexey Skobkin skobkin
0 followers · 4 following
Repositories
22
 Projects Packages Public activity Starred repositories
4
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 03:33:06 +03:00
882b4df5e1 #7 Notifier is now able to process real FeedItem objects.
54cded15e5 #7 Code style changes recommended by pylint.
Compare 2 commits »
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 03:24:08 +03:00
3032c642be #7 Code style changes recommended by pylint.
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 03:17:13 +03:00
9e4488b204 #7 Code style changes recommended by pylint.
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 03:02:11 +03:00
93610e4084 #7 Database integration. All basic commands implemented in CommandProcessor. Two telegram update middlewares implemented (UserAuthMiddleware, ExceptionHandlerMiddleware).
dbdb256359 #6 #7 Adding feed operation methods to the Database class. Creating custom DisplayableException for future usage in CommandProcessor. Some PEP-8 code style changes.
Compare 2 commits »
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 00:36:33 +03:00
305f1afa3c #7 Moving from package to module.
dc314b4599 #7 Code style changes.
c0148c2c91 #7 Making more detailed logic of notification. Slight refactoring.
5509053bb0 #7 Implementing Telegram bot run script.
8f359847bf #11 pylama. Hiding pylama installation in Drone CI logs.
Compare 9 commits »
skobkin pushed to feature_telegram at Miroslavsckaya/tg_rss_bot 2022-05-30 00:33:58 +03:00
74bd517238 #7 Moving from package to module.
7327f2c893 telegram. Code style changes.
b91f6d1edf telegram. Making more detailed logic of notification. Slight refactoring.
3b3438eab2 telegram. Implementing Telegram bot run script.
7ecd2df49f pylama. Hiding pylama installation in Drone CI logs.
Compare 19 commits »
skobkin approved Miroslavsckaya/tg_rss_bot#17 2022-05-29 23:18:15 +03:00
database_module

Good enough.

skobkin approved Miroslavsckaya/tg_rss_bot#19 2022-05-29 23:12:48 +03:00
RSS module

LGTM

skobkin commented on issue Miroslavsckaya/tg_rss_bot#3 2022-05-29 17:48:43 +03:00
RSS feed retrieval

Let's use feedparser:

skobkin pushed to master at skobkin/linux-config 2022-05-28 23:56:01 +03:00
f8c458b4e3 desktop. 5.18.0 oldconfig. CONFIG_X86_KERNEL_IBT disabled.
skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:14:15 +03:00
database_module

It's better to have consistency in the code style.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:04:20 +03:00
database_module

subscribes is a verb. "User subscribes to the feed".

skobkin suggested changes for Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:04:20 +03:00
database_module

Things are getting interesting. Looking forward to see this finished 😺

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:04:20 +03:00
database_module

subscribes

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:04:20 +03:00
database_module

By the way as you're selecting not the subscriptions themselves but the feeds users subscribed to it could be better to call this something like get_user_feeds().

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-28 23:01:54 +03:00
database_module

By the way as you're selecting not the subscriptions themselves but the feeds users subscribed to it could be better to call this something like get_user_feeds().

skobkin suggested changes for Miroslavsckaya/tg_rss_bot#17 2022-05-22 23:07:47 +03:00
database_module

Looks good, but here's a couple of things to make better.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-22 23:07:47 +03:00
database_module

It's better to call this url instead of link.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-22 23:07:47 +03:00
database_module

There is a semantic convention about database interaction method naming and behavior.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#17 2022-05-22 23:07:47 +03:00
database_module

I think it's most likely row (or data) than user_id.