Alexey Skobkin skobkin
0 followers · 4 following
Repositories
22
 Projects Packages Public activity Starred repositories
4
skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 23:17:45 +03:00
Update manager

If we're using title now, we can show the title here and make it a link to the feed URL.

skobkin opened issue Miroslavsckaya/tg_rss_bot#24 2022-06-12 17:54:41 +03:00
Use logger
skobkin suggested changes for Miroslavsckaya/tg_rss_bot#23 2022-06-12 17:00:48 +03:00
Update manager

Better, but still some things to improve.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 17:00:48 +03:00
Update manager

Just import FeedParserDict.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 17:00:48 +03:00
Update manager

It's just 3 lines. You can just do that in the constructor.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 17:00:48 +03:00
Update manager

old_items_urls (plural, same goes for method name)

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:49:42 +03:00
Update manager

There still an entrypoint script to implement besides other fixes by the way.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:48:22 +03:00
Update manager

So many space in the end of the file. Is it reserved for future improvements? 😄

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Why would you do that instead of just returning ready-for-use list of ID's from the Database?

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

The same as above goes here.

skobkin suggested changes for Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Looks fine, but some things could be improved.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Why? What is it for?

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Typehints for properties would also be good too.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Do you really need a date here?

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

Maybe we can use more specific type-hint here.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

We're forgetting about the feed itself creating small UX problem for the bot user here. But it can be addressed later.

skobkin commented on pull request Miroslavsckaya/tg_rss_bot#23 2022-06-12 01:46:46 +03:00
Update manager

By the way, you can move all logic from RssReader.__get_items() and RssReader.__convert_to_feed_item() to the FeedItem itself.

skobkin deleted branch feature_inbucket from skobkin/docker-stacks 2022-05-31 21:53:50 +03:00
skobkin pushed to master at skobkin/docker-stacks 2022-05-31 21:53:50 +03:00
892a697c9c Merge pull request 'inbucket. fix pop3 port binding.' (#42) from feature_inbucket into master
a8276a3341 inbucket. fix pop3 port binding.
Compare 2 commits »
skobkin merged pull request skobkin/docker-stacks#42 2022-05-31 21:53:49 +03:00
inbucket. fix pop3 port binding.