- Arkhangelsk, Russia
- https://skobk.in
- Joined on
2022-03-02
I don't think we really need it right now. We can open it back later.
I'd add database and logging configuration examples here too, but leave them commented to show that they're optional.
If you're providing docker-compose.yml with PostgreSQL service included, you can at least configure the database and DSN out-of-the box there.
It's better to remove that if you're not sure that you need to have static container name without stack prefix.
As you decided to also add Docker Compose configuration here, we now have some things to improve again 😆
If you're using substitution, then it'd be also good to provide an example file like .env.dist which could be simply copied to the .env file and quickly edited before the run.
I also don't see why not to use the same variable name here to make .env file interoperable between direct python usage and Docker Compose.
If you're providing docker-compose.yml with PostgreSQL service included, you can at least configure the database and DSN out-of-the box there.
I also don't see why not to use the same variable name here to make .env file interoperable between direct python usage and Docker Compose.
I'd recommend to also declare variables used by the app here. It can be done without specifying default value.