Alexey Skobkin skobkin
0 followers · 4 following
Repositories
22
 Projects Packages Public activity Starred repositories
4
skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I'd suggest explicitly defining which request methods we're processing here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I can't leave you a comment on src/Controller/.gitignore, so I'll ask here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Please do not forget declare(strict_types=1);

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

You're violating Symfony code style here which as I can guess you used above.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Just set a name for your route and you won't need such workarounds.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I see you needed some space 🤔

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Do we need double quotes here?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

You should add some placeholder value here like your_secret_please_set_on_local_env.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

This should probably not be here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I'd suggest we move to route list in YAML here before merging it. But it's not a main priority for now. Just let this thread be until we ready with everything else.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Do you really need this bool flag?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Please do not forget declare(strict_types=1);

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I'd suggest explicitly defining Table attribute here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

I'd also suggest to make this entity readonly. It'll give some performance benefits.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

No need for double quotes here too.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Why double quotes?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

You don't need this.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

Same code style problem like above. You're leaving { on the same line with return type.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

You don't need this.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-07-20 21:41:13 +03:00
WIP: feature_paste

You don't really need EntityManager here.