Alexey Skobkin skobkin
0 followers · 4 following
Repositories
22
 Projects Packages Public activity Starred repositories
4
skobkin merged pull request skobkin/docker-stacks#67 2023-08-15 23:58:28 +03:00
emby: GPU acceleration device pass
skobkin pushed to master at skobkin/docker-stacks 2023-08-15 23:58:28 +03:00
4b2fc426c9 emby: GPU acceleration device pass (#67)
skobkin deleted branch feature_emby_video_acceleration from skobkin/docker-stacks 2023-08-15 23:58:28 +03:00
skobkin pushed to feature_emby_video_acceleration at skobkin/docker-stacks 2023-08-15 23:57:09 +03:00
7d94bcef3a emby. Adding ability to pass video acceleration device to the container.
skobkin created pull request skobkin/docker-stacks#67 2023-08-15 23:46:16 +03:00
emby: GPU acceleration device pass
skobkin created branch feature_emby_video_acceleration in skobkin/docker-stacks 2023-08-15 23:45:07 +03:00
skobkin pushed to feature_emby_video_acceleration at skobkin/docker-stacks 2023-08-15 23:45:07 +03:00
skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:19:24 +03:00
WIP: feature_paste

Why 128?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:17:44 +03:00
WIP: feature_paste

You can use self as return type hint too.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:14:46 +03:00
WIP: feature_paste

This shouldn't be here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:13:10 +03:00
WIP: feature_paste

Why Entity?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:10:15 +03:00
WIP: feature_paste

Why 128?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:07:38 +03:00
WIP: feature_paste

BTW, if you're including it in the show_paste.html.twig, then you don't need to extend base.html.twig here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:03:34 +03:00
WIP: feature_paste

show_paste at least.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

Same here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

Why double quotes again?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

As I said above, better implement Twig extension and use it here.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

Why so specific?

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

It's better not to rely on external CDN's when you can.

skobkin commented on pull request Miroslavsckaya/copypaste#1 2023-08-06 14:01:58 +03:00
WIP: feature_paste

Why do you use HTML here and not in the template? Check the comment I left in PasterController::showPaste().