skobkin/point-tools
1
1
Fork 0
Code Issues 4 Pull requests 1 Releases Activity

Common User repository via class property.

Browse source
This commit is contained in:
Alexey Skobkin 2015-10-05 04:02:06 +03:00
parent c3191d82e6
commit f8bd95360e
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/Skobkin/Bundle/PointToolsBundle/Service/UserApi.php
View file

@ -32,12 +32,18 @@ class UserApi extends AbstractApi
*/ */
protected $em; protected $em;
/**
* @var EntityRepository
*/
protected $userRepository;
public function __construct(Client $httpClient, $https = true, $baseUrl = null, EntityManagerInterface $entityManager) public function __construct(Client $httpClient, $https = true, $baseUrl = null, EntityManagerInterface $entityManager)
{ {
parent::__construct($httpClient, $https, $baseUrl); parent::__construct($httpClient, $https, $baseUrl);
$this->em = $entityManager; $this->em = $entityManager;
$this->userRepository = $this->em->getRepository('SkobkinPointToolsBundle:User');
} }
public function getName() public function getName()
@ -190,13 +196,10 @@ class UserApi extends AbstractApi
throw new \InvalidArgumentException('$userInfo must be an array'); throw new \InvalidArgumentException('$userInfo must be an array');
} }
/** @var EntityRepository $userRepo */
$userRepo = $this->em->getRepository('SkobkinPointToolsBundle:User');
// @todo Return ID existance check when @ap-Codkelden will fix this API behaviour // @todo Return ID existance check when @ap-Codkelden will fix this API behaviour
if (array_key_exists('id', $userInfo) && array_key_exists('login', $userInfo) && array_key_exists('name', $userInfo) && is_numeric($userInfo['id'])) { if (array_key_exists('id', $userInfo) && array_key_exists('login', $userInfo) && array_key_exists('name', $userInfo) && is_numeric($userInfo['id'])) {
/** @var User $user */ /** @var User $user */
if (null === ($user = $userRepo->find($userInfo['id']))) { if (null === ($user = $this->userRepository->find($userInfo['id']))) {
// Creating new user // Creating new user
$user = new User($userInfo['id']); $user = new User($userInfo['id']);
$this->em->persist($user); $this->em->persist($user);
@ -234,9 +237,6 @@ class UserApi extends AbstractApi
throw new \InvalidArgumentException('$users must be an array'); throw new \InvalidArgumentException('$users must be an array');
} }
/** @var EntityRepository $userRepo */
$userRepo = $this->em->getRepository('SkobkinPointToolsBundle:User');
/** @var User[] $resultUsers */ /** @var User[] $resultUsers */
$resultUsers = []; $resultUsers = [];
@ -244,7 +244,7 @@ class UserApi extends AbstractApi
if (array_key_exists('id', $userInfo) && array_key_exists('login', $userInfo) && array_key_exists('name', $userInfo) && is_numeric($userInfo['id'])) { if (array_key_exists('id', $userInfo) && array_key_exists('login', $userInfo) && array_key_exists('name', $userInfo) && is_numeric($userInfo['id'])) {
// @todo Optimize with prehashed id's list // @todo Optimize with prehashed id's list
if (null === ($user = $userRepo->find($userInfo['id']))) { if (null === ($user = $this->userRepository->find($userInfo['id']))) {
$user = new User((int) $userInfo['id']); $user = new User((int) $userInfo['id']);
$this->em->persist($user); $this->em->persist($user);
} }