skobkin/point-tools
1
1
Fork 0
Code Issues 4 Pull requests 1 Releases Activity

Check for first-time processing removed from SubscriptionsManager. SubscriptionsManager optimized and slightly refactored.

Browse source
This commit is contained in:
Alexey Skobkin 2017-01-08 17:13:51 +03:00
parent cc29168d83
commit cfd30a093d
1 changed files with 53 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

95
src/Skobkin/Bundle/PointToolsBundle/Service/SubscriptionsManager.php
View file

@ -34,7 +34,6 @@ class SubscriptionsManager
*/ */
public function updateUserSubscribers(User $user, $newSubscribersList = []) public function updateUserSubscribers(User $user, $newSubscribersList = [])
{ {
/** @var Subscription[] $tmpOldSubscribers */
$tmpOldSubscribers = $user->getSubscribers(); $tmpOldSubscribers = $user->getSubscribers();
$oldSubscribersList = []; $oldSubscribersList = [];
@ -43,52 +42,17 @@ class SubscriptionsManager
$oldSubscribersList[] = $subscription->getSubscriber(); $oldSubscribersList[] = $subscription->getSubscriber();
} }
// @todo remove
$isFirstTime = false;
// Preventing to add garbage subscriptions for first processing
// @todo improve algorithm
if ((count($oldSubscribersList) === 0) && (count($newSubscribersList) > 1)) {
$isFirstTime = true;
}
unset($tmpOldSubscribers);
$subscribedList = $this->getUsersListsDiff($newSubscribersList, $oldSubscribersList); $subscribedList = $this->getUsersListsDiff($newSubscribersList, $oldSubscribersList);
$unsubscribedList = $this->getUsersListsDiff($oldSubscribersList, $newSubscribersList); $unsubscribedList = $this->getUsersListsDiff($oldSubscribersList, $newSubscribersList);
/** @var User $subscribedUser */ $this->processSubscribedUsers($user, $subscribedList);
foreach ($subscribedList as $subscribedUser) { $this->processUnsubscribedUsers($user, $unsubscribedList);
$subscription = new Subscription($user, $subscribedUser);
$user->addSubscriber($subscription);
$this->em->persist($subscription);
// If it's not first processing
if (!$isFirstTime) {
$logEvent = new SubscriptionEvent($user, $subscribedUser, SubscriptionEvent::ACTION_SUBSCRIBE);
$this->em->persist($logEvent);
$user->addNewSubscriberEvent($logEvent);
}
}
/** @var User $unsubscribedUser */
foreach ($unsubscribedList as $unsubscribedUser) {
$logEvent = new SubscriptionEvent($user, $unsubscribedUser, SubscriptionEvent::ACTION_UNSUBSCRIBE);
$this->em->persist($logEvent);
$user->addNewSubscriberEvent($logEvent);
}
// Removing users from database // Removing users from database
// @todo Maybe remove via ORM
$this->em->getRepository('SkobkinPointToolsBundle:Subscription')->removeSubscribers($user, $unsubscribedList); $this->em->getRepository('SkobkinPointToolsBundle:Subscription')->removeSubscribers($user, $unsubscribedList);
if (0 !== count($subscribedList) || 0 !== count($unsubscribedList)) { $this->dispatchSubscribersUpdatedEvent($user, $subscribedList, $unsubscribedList);
// Dispatching event
$subscribersUpdatedEvent = new UserSubscribersUpdatedEvent($user, $subscribedList, $unsubscribedList);
$this->eventDispatcher->dispatch(UserSubscribersUpdatedEvent::NAME, $subscribersUpdatedEvent);
}
} }
/** /**
@ -97,9 +61,9 @@ class SubscriptionsManager
* @param User[] $list1 * @param User[] $list1
* @param User[] $list2 * @param User[] $list2
* *
* @return User[] Diff * @return User[]
*/ */
public function getUsersListsDiff(array $list1 = [], array $list2 = []) public function getUsersListsDiff(array $list1 = [], array $list2 = []): array
{ {
$hash1 = []; $hash1 = [];
$hash2 = []; $hash2 = [];
@ -113,4 +77,51 @@ class SubscriptionsManager
return array_diff_key($hash1, $hash2); return array_diff_key($hash1, $hash2);
} }
/**
* @param User $user
* @param User[] $subscribers
*/
private function processSubscribedUsers(User $user, array $subscribers)
{
foreach ($subscribers as $subscriber) {
$subscription = new Subscription($user, $subscriber);
$user->addSubscriber($subscription);
$this->em->persist($subscription);
$logEvent = new SubscriptionEvent($user, $subscriber, SubscriptionEvent::ACTION_SUBSCRIBE);
$this->em->persist($logEvent);
$user->addNewSubscriberEvent($logEvent);
}
}
/**
* @param User $user
* @param User[] $subscribers
*/
private function processUnsubscribedUsers(User $user, array $subscribers)
{
foreach ($subscribers as $subscriber) {
$logEvent = new SubscriptionEvent($user, $subscriber, SubscriptionEvent::ACTION_UNSUBSCRIBE);
$this->em->persist($logEvent);
$user->addNewSubscriberEvent($logEvent);
}
}
/**
* @param User $user
* @param User[] $subscribed
* @param User[] $unsubscribed
*/
private function dispatchSubscribersUpdatedEvent(User $user, array $subscribed, array $unsubscribed)
{
if (0 !== count($subscribed) || 0 !== count($unsubscribed)) {
// Dispatching event
$subscribersUpdatedEvent = new UserSubscribersUpdatedEvent($user, $subscribed, $unsubscribed);
$this->eventDispatcher->dispatch(UserSubscribersUpdatedEvent::NAME, $subscribersUpdatedEvent);
}
}
} }