From a9f53f3b257dbabce0f5122633b2d8399e28fc66 Mon Sep 17 00:00:00 2001 From: Alexey Skobkin Date: Tue, 2 Jun 2015 05:05:03 +0300 Subject: [PATCH] Better logger usage. --- .../Command/UpdateSubscriptionsCommand.php | 20 ++++--------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/Skobkin/Bundle/PointToolsBundle/Command/UpdateSubscriptionsCommand.php b/src/Skobkin/Bundle/PointToolsBundle/Command/UpdateSubscriptionsCommand.php index 9986a4a..9a0b82c 100644 --- a/src/Skobkin/Bundle/PointToolsBundle/Command/UpdateSubscriptionsCommand.php +++ b/src/Skobkin/Bundle/PointToolsBundle/Command/UpdateSubscriptionsCommand.php @@ -69,10 +69,7 @@ class UpdateSubscriptionsCommand extends ContainerAwareCommand } catch (\Exception $e) { // @todo fallback to the local subscribers list $output->writeln('Error while getting service subscribers'); - $log->error('Error while getting service subscribers.' . PHP_EOL . - $e->getMessage() . PHP_EOL . - $e->getFile() . ':' . $e->getLine() - ); + $log->error('Error while getting service subscribers.', ['message' => $e->getMessage(), 'file' => $e->getFile(), 'line' => $e->getLine()]); return false; } @@ -85,10 +82,7 @@ class UpdateSubscriptionsCommand extends ContainerAwareCommand try { $subscriptionsManager->updateUserSubscribers($serviceUser, $serviceSubscribers); } catch (\Exception $e) { - $log->error('Error while updating service subscribers' . PHP_EOL . - $e->getMessage() . PHP_EOL . - $e->getFile() . ':' . $e->getLine() - ); + $log->error('Error while updating service subscribers', ['message' => $e->getMessage(), 'file' => $e->getFile(), 'line' => $e->getLine()]); return false; } @@ -106,10 +100,7 @@ class UpdateSubscriptionsCommand extends ContainerAwareCommand $userCurrentSubscribers = $api->getUserSubscribersById($user->getId()); } catch (\Exception $e) { $output->writeln(' Error while getting subscribers. Skipping.'); - $log->error('Error while getting subscribers.' . PHP_EOL . - $e->getMessage() . PHP_EOL . - $e->getFile() . ':' . $e->getLine() - ); + $log->error('Error while getting subscribers.', ['message' => $e->getMessage(), 'file' => $e->getFile(), 'line' => $e->getLine()]); continue; } @@ -122,10 +113,7 @@ class UpdateSubscriptionsCommand extends ContainerAwareCommand // Updating user subscribers $subscriptionsManager->updateUserSubscribers($user, $userCurrentSubscribers); } catch (\Exception $e) { - $log->error('Error while updating user subscribers' . PHP_EOL . - $e->getMessage() . PHP_EOL . - $e->getFile() . ':' . $e->getLine() - ); + $log->error('Error while updating user subscribers', ['message' => $e->getMessage(), 'file' => $e->getFile(), 'line' => $e->getLine()]); } // @todo move to the config