skobkin/point-tools
1
1
Fork 0
Code Issues 4 Pull requests 1 Releases Activity

Fixina small MainControllerTest problems.

Browse source
This commit is contained in:
Alexey Skobkin 2019-04-03 19:38:57 +03:00
parent 7fcdcbf728
commit 9e5f59a2b2
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
composer.json
View file

@ -13,6 +13,7 @@
}, },
"require": { "require": {
"php": ">=7.1.0", "php": ">=7.1.0",
"ext-json": "*",
"symfony/symfony": "^3.4", "symfony/symfony": "^3.4",
"doctrine/orm": "^2.5", "doctrine/orm": "^2.5",
"doctrine/annotations": "^1.3.0", "doctrine/annotations": "^1.3.0",

19
tests/Skobkin/PointToolsBundle/Controller/MainControllerTest.php
View file

@ -2,13 +2,12 @@
namespace Tests\Skobkin\PointToolsBundle\Controller; namespace Tests\Skobkin\PointToolsBundle\Controller;
use Skobkin\Bundle\PointToolsBundle\DataFixtures\ORM\LoadUserData;
use Symfony\Bundle\FrameworkBundle\Client; use Symfony\Bundle\FrameworkBundle\Client;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase; use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
class MainControllerTest extends WebTestCase class MainControllerTest extends WebTestCase
{ {
public function testUserSearch() public function testUserSearch(): void
{ {
$client = static::createClient(); $client = static::createClient();
$crawler = $client->request('GET', '/'); $crawler = $client->request('GET', '/');
@ -21,7 +20,7 @@ class MainControllerTest extends WebTestCase
$this->assertTrue($client->getResponse()->isRedirect('/user/testuser'), 'Redirect to testuser\'s page didn\'t happen'); $this->assertTrue($client->getResponse()->isRedirect('/user/testuser'), 'Redirect to testuser\'s page didn\'t happen');
} }
public function testNonExistingUserSearch() public function testNonExistingUserSearch(): void
{ {
$client = static::createClient(); $client = static::createClient();
$crawler = $client->request('GET', '/'); $crawler = $client->request('GET', '/');
@ -51,7 +50,7 @@ class MainControllerTest extends WebTestCase
$this->assertEquals(' Login not found', $firstError->text(), 'Incorrect error text'); $this->assertEquals(' Login not found', $firstError->text(), 'Incorrect error text');
} }
public function testUserStats() public function testUserStats(): void
{ {
$client = static::createClient(); $client = static::createClient();
$crawler = $client->request('GET', '/'); $crawler = $client->request('GET', '/');
@ -104,7 +103,7 @@ class MainControllerTest extends WebTestCase
/** /**
* @depends testAjaxUserAutoCompleteHasOptions * @depends testAjaxUserAutoCompleteHasOptions
*/ */
public function testAjaxUserAutoCompleteHasValidUserObjects(array $users) public function testAjaxUserAutoCompleteHasValidUserObjects(array $users): void
{ {
foreach ($users as $key => $user) { foreach ($users as $key => $user) {
$this->assertTrue(array_key_exists('login', $user), sprintf('%d row of result has \'login\' field', $key)); $this->assertTrue(array_key_exists('login', $user), sprintf('%d row of result has \'login\' field', $key));
@ -132,7 +131,7 @@ class MainControllerTest extends WebTestCase
$data = json_decode($json, true); $data = json_decode($json, true);
$this->assertNotNull($data, 'JSON data successfully decoded and not empty'); $this->assertNotNull($data, 'JSON data successfully decoded and not empty');
$this->assertTrue(is_array($data), 'JSON data is array'); $this->assertInternalType('array', $data, 'JSON data is array');
$this->assertCount(1, $data, 'Array has 1 elements'); $this->assertCount(1, $data, 'Array has 1 elements');
return reset($data); return reset($data);
@ -141,7 +140,7 @@ class MainControllerTest extends WebTestCase
/** /**
* @depends testAjaxUserAutoCompleteHasOptionsForUnnamedUser * @depends testAjaxUserAutoCompleteHasOptionsForUnnamedUser
*/ */
public function testAjaxUserAutoCompleteHasValidUserObjectsForUnnamedUser(array $user) public function testAjaxUserAutoCompleteHasValidUserObjectsForUnnamedUser(array $user): void
{ {
$this->assertTrue(array_key_exists('login', $user), 'Result has \'login\' field'); $this->assertTrue(array_key_exists('login', $user), 'Result has \'login\' field');
$this->assertTrue(array_key_exists('name', $user), 'Result has \'name\' field'); $this->assertTrue(array_key_exists('name', $user), 'Result has \'name\' field');
@ -149,7 +148,7 @@ class MainControllerTest extends WebTestCase
$this->assertEquals('', $user['name'], 'User name is empty string'); $this->assertEquals('', $user['name'], 'User name is empty string');
} }
public function testAjaxUserAutoCompleteIsEmptyForNonExistingUser() public function testAjaxUserAutoCompleteIsEmptyForNonExistingUser(): void
{ {
$client = static::createClient(); $client = static::createClient();
$client->request('GET', '/ajax/users/search/aksdjhaskdjhqwhdgqkjwhdgkjah'); $client->request('GET', '/ajax/users/search/aksdjhaskdjhqwhdgqkjwhdgkjah');
@ -159,8 +158,8 @@ class MainControllerTest extends WebTestCase
$data = json_decode($client->getResponse()->getContent()); $data = json_decode($client->getResponse()->getContent());
$this->assertNotNull($data, 'JSON data successfully decoded and not empty'); $this->assertNotNull($data, 'JSON data successfully decoded and not empty');
$this->assertTrue(is_array($data), 'JSON data is array'); $this->assertInternalType('array', $data, 'JSON data is array');
$this->assertEquals(0, count($data), 'Array has no elements'); $this->assertCount(0, $data, 'Array has no elements');
} }
private function createClientForAjaxUserSearchByLogin(string $login): Client private function createClientForAjaxUserSearchByLogin(string $login): Client