skobkin/point-tools
1
1
Fork 0
Code Issues 4 Pull requests 1 Releases Activity

New PHP 7.1 type hints for factories.

Browse source
This commit is contained in:
Alexey Skobkin 2017-01-13 02:21:17 +03:00
parent 415efe9e6e
commit 5271fd5f59
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Skobkin/Bundle/PointToolsBundle/Service/Factory/Blogs/CommentFactory.php
View file

@ -88,7 +88,7 @@ class CommentFactory
*
* @throws InvalidResponseException
*/
private function validateData(array $data)
private function validateData(array $data): void
{
if (!array_key_exists('author', $data)) {
throw new InvalidResponseException('Comment author data not found in API response');

2
src/Skobkin/Bundle/PointToolsBundle/Service/Factory/Blogs/FileFactory.php
View file

@ -76,7 +76,7 @@ class FileFactory
*
* @throws InvalidResponseException
*/
private function validateData($data)
private function validateData($data): void
{
if (!is_string($data)) {
// @todo Change exception

6
src/Skobkin/Bundle/PointToolsBundle/Service/Factory/Blogs/PostFactory.php
View file

@ -180,7 +180,7 @@ class PostFactory
* @param Post $post
* @param string[] $tagsStrings
*/
private function updatePostTags(Post $post, array $tagsStrings)
private function updatePostTags(Post $post, array $tagsStrings): void
{
$tags = $this->tagFactory->createFromStringsArray($tagsStrings);
@ -224,7 +224,7 @@ class PostFactory
* @param Post $post
* @param array $urls
*/
private function updatePostFiles(Post $post, array $urls)
private function updatePostFiles(Post $post, array $urls): void
{
$files = $this->fileFactory->createFromUrlsArray($urls);
@ -243,7 +243,7 @@ class PostFactory
}
}
private function validateMetaPost(MetaPost $post)
private function validateMetaPost(MetaPost $post): bool
{
if (!$post->getPost()->getId()) {
$this->logger->error('Post DTO contains no id');

4
src/Skobkin/Bundle/PointToolsBundle/Service/Factory/UserFactory.php
View file

@ -85,7 +85,7 @@ class UserFactory
*
* @throws InvalidResponseException
*/
private function validateArrayData(array $data)
private function validateArrayData(array $data): void
{
if (!array_key_exists('id', $data) || !array_key_exists('login', $data) || !array_key_exists('name', $data) || !is_numeric($data['id'])) {
throw new InvalidResponseException('Invalid user data');
@ -97,7 +97,7 @@ class UserFactory
*
* @throws InvalidResponseException
*/
private function validateDTOData(UserDTO $data)
private function validateDTOData(UserDTO $data): void
{
if (!$data->getId() || !$data->getLogin()) {
throw new InvalidUserDataException('User have no id or login', $data);