Miroslavsckaya/copypaste
1
0
Fork 0
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

WIP: feature_paste #1

Draft
Miroslavsckaya wants to merge 24 commits from feature_paste into master
pull from: feature_paste
merge into: Miroslavsckaya:master
Conversation 0 Commits 24 Files changed 31 +8 -9
5 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ea7ddcde65 - Show all commits

2
migrations/Version20230720115905.php
View file

@ -13,7 +13,7 @@ final class Version20230720115905 extends AbstractMigration
public function up(Schema $schema): void public function up(Schema $schema): void
skobkin marked this conversation as resolved
skobkin commented 2023-07-21 22:27:19 +00:00
Review
Copy link

Do you need it here if it's empty?

Do you need it here if it's empty?
👍 1
{ {
$this->addSql('CREATE SEQUENCE paste_id_seq INCREMENT BY 1 MINVALUE 1 START 1'); $this->addSql('CREATE SEQUENCE paste_id_seq INCREMENT BY 1 MINVALUE 1 START 1');
$this->addSql('CREATE TABLE paste (id INT NOT NULL, text TEXT NOT NULL, language VARCHAR(25), description TEXT, filename VARCHAR(128), author VARCHAR(128) NOT NULL, publish_date TIMESTAMP(0) WITHOUT TIME ZONE NOT NULL, expiration_date TIMESTAMP(0) WITHOUT TIME ZONE, ip VARCHAR(15) NOT NULL, secret VARCHAR(40), PRIMARY KEY(id))'); $this->addSql('CREATE TABLE paste (id INT NOT NULL, text TEXT NOT NULL, language VARCHAR(25), description TEXT, filename VARCHAR(128), author VARCHAR(128), publish_date TIMESTAMP(0) WITHOUT TIME ZONE NOT NULL, expiration_date TIMESTAMP(0) WITHOUT TIME ZONE, ip VARCHAR(15) NOT NULL, secret VARCHAR(40), PRIMARY KEY(id))');
} }
public function down(Schema $schema): void public function down(Schema $schema): void

5
src/DTO/PasteFormData.php
View file

@ -15,8 +15,7 @@ class PasteFormData
public ?string $language = null; public ?string $language = null;
public ?string $description = null; public ?string $description = null;
public ?string $filename = null; public ?string $filename = null;
#[Assert\NotBlank] public ?string $author = null;
public string $author = 'anonymous';
public ?\DateTimeImmutable $expirationDate; public ?\DateTimeImmutable $expirationDate;
skobkin marked this conversation as resolved
skobkin commented 2023-07-21 22:36:37 +00:00
Review
Copy link

Why string and Assert\NotBlank?

Why `string` and `Assert\NotBlank`?
👍 1
public function __construct(?Paste $paste = null) public function __construct(?Paste $paste = null)
@ -30,7 +29,7 @@ class PasteFormData
$this->language = $paste->language; $this->language = $paste->language;
$this->description = $paste->description; $this->description = $paste->description;
$this->filename = $paste->filename; $this->filename = $paste->filename;
$this->author = $paste->author; $this->author = $paste->author !== null ? $paste->author : 'anonymous';
$this->expirationDate = $paste->expirationDate; $this->expirationDate = $paste->expirationDate;
} }
} }

4
src/Entity/Paste.php
View file

@ -23,8 +23,8 @@ class Paste
public readonly ?string $description, public readonly ?string $description,
#[ORM\Column(type: 'string', length: 128, nullable: true)] #[ORM\Column(type: 'string', length: 128, nullable: true)]
public readonly ?string $filename, public readonly ?string $filename,
skobkin commented 2023-08-06 11:10:15 +00:00
Review
Copy link

Why 128?

Why 128?
#[ORM\Column(type: 'string', length: 128, nullable: false)] #[ORM\Column(type: 'string', length: 128, nullable: true)]
public readonly string $author, public readonly ?string $author,
#[ORM\Column(type: 'datetime_immutable', nullable: false)] #[ORM\Column(type: 'datetime_immutable', nullable: false)]
public readonly \DateTimeImmutable $publishDate, public readonly \DateTimeImmutable $publishDate,
#[ORM\Column(type: 'datetime_immutable', nullable: true)] #[ORM\Column(type: 'datetime_immutable', nullable: true)]

2
src/Form/Type/PasteForm.php
View file

@ -28,7 +28,7 @@ class PasteForm extends AbstractType
) )
->add('description', TextType::class, ['required' => false]) ->add('description', TextType::class, ['required' => false])
->add('text', TextareaType::class) ->add('text', TextareaType::class)
->add('author', TextType::class, ['attr' => ['maxlength' =>128]]) ->add('author', TextType::class, ['attr' => ['maxlength' => 128], 'required' => false])
->add('filename', TextType::class, ['required' => false, 'attr' => ['maxlength' =>128]]) ->add('filename', TextType::class, ['required' => false, 'attr' => ['maxlength' =>128]])
skobkin commented 2023-08-06 11:19:24 +00:00
Review
Copy link

Why 128?

Why 128?
->add('expirationDate', DateTimeType::class, [ ->add('expirationDate', DateTimeType::class, [
'required' => false, 'required' => false,