Miroslavsckaya/copypaste
1
0
Fork 0
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

WIP: feature_paste #1

Draft
Miroslavsckaya wants to merge 24 commits from feature_paste into master
pull from: feature_paste
merge into: Miroslavsckaya:master
Conversation 0 Commits 24 Files changed 31 +7 -8
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ddfbba344a - Show all commits

15
src/Entity/Paste.php
View file

@ -4,7 +4,6 @@ declare(strict_types = 1);
namespace App\Entity; namespace App\Entity;
use App\DTO\PasteFormData; use App\DTO\PasteFormData;
use App\Repository\PasteRepository; use App\Repository\PasteRepository;
use Doctrine\DBAL\Types\Types;
use Doctrine\ORM\Mapping as ORM; use Doctrine\ORM\Mapping as ORM;
#[ORM\Entity(repositoryClass: PasteRepository::class)] #[ORM\Entity(repositoryClass: PasteRepository::class)]
skobkin commented 2023-07-20 18:17:34 +00:00
Review
Copy link

I'd suggest explicitly defining Table attribute here.

Especially since you're defining Column attributes below ⬇️

I'd suggest explicitly defining `Table` attribute here. Especially since you're defining `Column` attributes below ⬇️
skobkin commented 2023-07-20 18:24:07 +00:00
Review
Copy link

I'd also suggest to make this entity readonly. It'll give some performance benefits.

You can read about that here.

I'd also suggest to make this entity readonly. It'll give some performance benefits. You can read about that [here](https://www.doctrine-project.org/projects/doctrine-orm/en/2.15/reference/attributes-reference.html#attrref_entity).
👍 1
@ -18,21 +17,21 @@ class Paste
private function __construct( private function __construct(
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:20:17 +00:00
Outdated
Review
Copy link

No need for double quotes here too.

No need for double quotes here too.
👍 1
#[ORM\Column(type: 'text', nullable: false)] #[ORM\Column(type: 'text', nullable: false)]
public readonly string $text, public readonly string $text,
#[ORM\Column(length: 25, nullable: true)] #[ORM\Column(type: 'string', length: 25, nullable: true)]
public readonly ?string $language, public readonly ?string $language,
#[ORM\Column(type: 'text', nullable: true)] #[ORM\Column(type: 'text', nullable: true)]
public readonly ?string $description, public readonly ?string $description,
#[ORM\Column(length: 128, nullable: true)] #[ORM\Column(type: 'string', length: 128, nullable: true)]
public readonly ?string $filename, public readonly ?string $filename,
skobkin commented 2023-07-20 18:21:36 +00:00
Outdated
Review
Copy link

What type? Why 25 exactly?

What type? Why 25 exactly?
👍 1
skobkin commented 2023-08-06 11:10:15 +00:00
Review
Copy link

Why 128?

Why 128?
#[ORM\Column(length: 128, nullable: false)] #[ORM\Column(type: 'string', length: 128, nullable: false)]
public readonly string $author, public readonly string $author,
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-21 20:33:09 +00:00
Outdated
Review
Copy link

Why not nullable?

Why not nullable?
👍 1
#[ORM\Column(type: Types::DATETIME_IMMUTABLE, nullable: false)] #[ORM\Column(type: 'datetime_immutable', nullable: false)]
public readonly \DateTimeImmutable $publishDate, public readonly \DateTimeImmutable $publishDate,
#[ORM\Column(type: Types::DATETIME_IMMUTABLE, nullable: true)] #[ORM\Column(type: 'datetime_immutable', nullable: true)]
public readonly ?\DateTimeImmutable $expirationDate, public readonly ?\DateTimeImmutable $expirationDate,
#[ORM\Column(length: 15, nullable: false)] #[ORM\Column(type: 'string', length: 15, nullable: false)]
public readonly string $ip, public readonly string $ip,
skobkin marked this conversation as resolved
skobkin commented 2023-07-21 22:19:40 +00:00
Review
Copy link

IPv6?

IPv6?
👍 1
#[ORM\Column(length: 40, nullable: true)] #[ORM\Column(type: 'string', length: 40, nullable: true)]
public readonly ?string $secret, public readonly ?string $secret,
) {} ) {}
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:22:04 +00:00
Outdated
Review
Copy link

Why double quotes?

Why double quotes?
👍 1