Miroslavsckaya/copypaste
1
0
Fork 0
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

WIP: feature_paste #1

Draft
Miroslavsckaya wants to merge 24 commits from feature_paste into master
pull from: feature_paste
merge into: Miroslavsckaya:master
Conversation 0 Commits 24 Files changed 31 +3 -3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a442fe31f9 - Show all commits

6
src/Controller/PasteController.php
View file

@ -15,7 +15,7 @@ use Symfony\Component\HttpFoundation\Request;
class PasteController extends AbstractController class PasteController extends AbstractController
{ {
skobkin commented 2023-07-20 18:04:53 +00:00
Review
Copy link

I'd suggest explicitly defining which request methods we're processing here.

P.S. We'll move this to YAML in the end.

I'd suggest explicitly defining which request methods we're processing here. P.S. We'll move this to YAML in the end.
#[Route('/')] #[Route('/', name: 'homepage')]
public function new(Request $request, PasteRepository $pasteRepository): Response public function new(Request $request, PasteRepository $pasteRepository): Response
{ {
$pasteData = new PasteFormData(); $pasteData = new PasteFormData();
@ -28,7 +28,7 @@ class PasteController extends AbstractController
$paste = Paste::fromFormDataAndIp($pasteData, $request->getClientIp()); $paste = Paste::fromFormDataAndIp($pasteData, $request->getClientIp());
$pasteRepository->save($paste, true); $pasteRepository->save($paste, true);
return $this->redirectToRoute($request->attributes->get('_route')); return $this->redirectToRoute('showpaste', ['id' => $paste->id, 'secret' => $paste->secret]);
} }
return $this->render('paste.html.twig', [ return $this->render('paste.html.twig', [
@ -36,7 +36,7 @@ class PasteController extends AbstractController
]); ]);
} }
#[Route('/{id}/{secret}')] #[Route('/{id}/{secret}', name: 'showpaste')]
public function showPaste(PasteRepository $pasteRepository, string $id, ?string $secret = NULL): Response public function showPaste(PasteRepository $pasteRepository, string $id, ?string $secret = NULL): Response
skobkin commented 2023-08-06 11:03:34 +00:00
Review
Copy link

show_paste at least.

`show_paste` at least.
{ {
$paste = $pasteRepository->findOneBy(['id' => $id, 'secret' => $secret]); $paste = $pasteRepository->findOneBy(['id' => $id, 'secret' => $secret]);