Miroslavsckaya/copypaste
1
0
Fork 0
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

WIP: feature_paste #1

Draft
Miroslavsckaya wants to merge 24 commits from feature_paste into master
pull from: feature_paste
merge into: Miroslavsckaya:master
Conversation 0 Commits 24 Files changed 31 +6 -3
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 8bceb97550 - Show all commits

2
src/Controller/PasteController.php
View file

@ -27,7 +27,7 @@ class PasteController extends AbstractController
$pasteData->ip = $request->getClientIp(); $pasteData->ip = $request->getClientIp();
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-22 17:48:11 +00:00
Outdated
Review
Copy link

Do you need IP in PasteData?

Do you need IP in `PasteData`?
👍 1
$paste = Paste::fromFormData($pasteData); $paste = Paste::fromFormData($pasteData);
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:09:54 +00:00
Outdated
Review
Copy link

Do we need double quotes here?

By the way, we can also do that in the constructor.

Do we need double quotes here? By the way, we can also do that in the constructor.
👍 1
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-21 22:38:05 +00:00
Outdated
Review
Copy link

This still could be done in the entity itself.

This still could be done in the entity itself.
👍 1
$pasteRepository->save($paste); $pasteRepository->save($paste, true);
return $this->redirectToRoute($request->attributes->get('_route')); return $this->redirectToRoute($request->attributes->get('_route'));
} }
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-21 22:29:02 +00:00
Outdated
Review
Copy link

I still suggest to make Paste::fromFormData().

I still suggest to make `Paste::fromFormData()`.
👍 1

5
src/Repository/PasteRepository.php
View file

@ -14,10 +14,13 @@ class PasteRepository extends ServiceEntityRepository
parent::__construct($registry, Paste::class); parent::__construct($registry, Paste::class);
} }
public function save(Paste $paste): void public function save(Paste $paste, bool $flush=false): void
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-22 17:51:11 +00:00
Outdated
Review
Copy link

Do not forget to use code formatting. It'd surrounded = with spaces for you.

Do not forget to use code formatting. It'd surrounded `=` with spaces for you.
👍 1
{ {
$entityManager = $this->getEntityManager(); $entityManager = $this->getEntityManager();
$entityManager->persist($paste); $entityManager->persist($paste);
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-21 20:28:25 +00:00
Outdated
Review
Copy link

You shouldn't do flush here by default. Only in certain cases if needed.

You shouldn't do flush here by default. Only in certain cases if needed.
if ($flush) {
$entityManager->flush(); $entityManager->flush();
} }
} }
}