Miroslavsckaya/copypaste
1
0
Fork 0
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

WIP: feature_paste #1

Draft
Miroslavsckaya wants to merge 24 commits from feature_paste into master
pull from: feature_paste
merge into: Miroslavsckaya:master
Conversation 0 Commits 24 Files changed 31 +3 -5
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6a2f15d1d6 - Show all commits

3
src/Controller/PasteController.php
View file

@ -24,9 +24,8 @@ class PasteController extends AbstractController
$form->handleRequest($request); $form->handleRequest($request);
if ($form->isSubmitted() && $form->isValid()) { if ($form->isSubmitted() && $form->isValid()) {
$pasteData = $form->getData(); $pasteData = $form->getData();
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:09:30 +00:00
Outdated
Review
Copy link

You can just set it in the constructor.

You can just set it in the constructor.
👍 1
$pasteData->ip = $request->getClientIp();
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-22 17:48:11 +00:00
Outdated
Review
Copy link

Do you need IP in PasteData?

Do you need IP in `PasteData`?
👍 1
$paste = Paste::fromFormData($pasteData); $paste = Paste::fromFormDataAndIp($pasteData, $request->getClientIp());
$pasteRepository->save($paste, true); $pasteRepository->save($paste, true);
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:09:54 +00:00
Outdated
Review
Copy link

Do we need double quotes here?

By the way, we can also do that in the constructor.

Do we need double quotes here? By the way, we can also do that in the constructor.
👍 1
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-21 22:38:05 +00:00
Outdated
Review
Copy link

This still could be done in the entity itself.

This still could be done in the entity itself.
👍 1
return $this->redirectToRoute($request->attributes->get('_route')); return $this->redirectToRoute($request->attributes->get('_route'));

1
src/DTO/PasteFormData.php
View file

@ -18,7 +18,6 @@ class PasteFormData
#[Assert\NotBlank] #[Assert\NotBlank]
public string $author = 'anonymous'; public string $author = 'anonymous';
public ?\DateTimeImmutable $expirationDate; public ?\DateTimeImmutable $expirationDate;
skobkin marked this conversation as resolved
skobkin commented 2023-07-21 22:36:37 +00:00
Review
Copy link

Why string and Assert\NotBlank?

Why `string` and `Assert\NotBlank`?
👍 1
public string $ip;
public function __construct(?Paste $paste=null) public function __construct(?Paste $paste=null)
skobkin marked this conversation as resolved
skobkin commented 2023-07-22 18:00:09 +00:00
Review
Copy link

Is this validation being processed BEFORE storing the data in the DTO?
If not, it's pointless as with bool field earlier.

Is this validation being processed BEFORE storing the data in the DTO? If not, it's pointless as with `bool` field earlier.
👍 1
{ {

4
src/Entity/Paste.php
View file

@ -35,7 +35,7 @@ class Paste
public readonly ?string $secret, public readonly ?string $secret,
) {} ) {}
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:22:04 +00:00
Outdated
Review
Copy link

Why double quotes?

Why double quotes?
👍 1
public static function fromFormData(PasteFormData $pasteFormData): Paste public static function fromFormDataAndIp(PasteFormData $pasteFormData, $ip): Paste
skobkin commented 2023-08-06 11:17:44 +00:00
Review
Copy link

You can use self as return type hint too.

You can use `self` as return type hint too.
{ {
return new self( return new self(
skobkin marked this conversation as resolved Outdated
skobkin commented 2023-07-20 18:22:53 +00:00
Outdated
Review
Copy link

Why mutable date? Do you plan to change publish date?

Why mutable date? Do you plan to change publish date?
👍 1
$pasteFormData->text, $pasteFormData->text,
@ -45,7 +45,7 @@ class Paste
$pasteFormData->author, $pasteFormData->author,
new \DateTimeImmutable(), new \DateTimeImmutable(),
$pasteFormData->expirationDate, $pasteFormData->expirationDate,
$pasteFormData->ip, $ip,
$pasteFormData->private ? \hash('sha1', \random_bytes(25)) : null, $pasteFormData->private ? \hash('sha1', \random_bytes(25)) : null,
); );
} }